Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin importlib_metadata to version 7.2.1 #2925

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Pin importlib_metadata to version 7.2.1 #2925

merged 5 commits into from
Jun 25, 2024

Conversation

javerbukh
Copy link
Contributor

Description

This pull request is to address failing CI tests which relate to pypa/twine#977 (comment)

Fixes #

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@javerbukh javerbukh added this to the 3.10.3 milestone Jun 25, 2024
@javerbukh javerbukh added the no-changelog-entry-needed changelog bot directive label Jun 25, 2024
pllim
pllim reviewed Jun 25, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@javerbukh @pllim
Update pyproject.toml
3f66593 
Co-authored-by: P. L. Lim <[email protected]>
@pllim pllim added trivial Only needs one approval instead of two 💤backport-v3.10.x on-merge: backport to v3.10.x labels Jun 25, 2024
@pllim
Copy link
Contributor

pllim commented Jun 25, 2024

The pin isn't working. Maybe you should remove it from pyproject.toml and pin it here instead?

jdaviz/tox.ini

Line 112 in 8b954eb

deps =

and here

jdaviz/.github/workflows/publish.yml

Line 29 in 8b954eb

run: python -m pip install build "twine>=3.3"

@pllim
Not here
0fd160e 
[ci skip] [rtd skip]
@pllim
maybe here
8ab9ae2 
[ci skip] [rtd skip]
@pllim
And here
11dcb70 
Squash me!
pllim
pllim approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took liberty to fix it for you. Hope you don't mind. The previously failing jobs are green now, so approving.

@pllim pllim enabled auto-merge (squash) June 25, 2024 22:45
@pllim pllim merged commit 14f0e29 into spacetelescope:main Jun 25, 2024
16 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Jun 25, 2024
@javerbukh @meeseeksmachine
Backport PR spacetelescope#2925: Pin importlib_metadata to version 7.2.1
254b404
@meeseeksmachine meeseeksmachine mentioned this pull request Jun 25, 2024
Merged
@javerbukh javerbukh deleted the pin-importlib-metadata branch June 26, 2024 11:11
pllim added a commit that referenced this pull request Jun 26, 2024
@pllim
Merge pull request #2926 from meeseeksmachine/auto-backport-of-pr-292…
a66ef3a 
…5-on-v3.10.x

Backport PR #2925 on branch v3.10.x (Pin importlib_metadata to version 7.2.1)
@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (db907c8) to head (11dcb70).
Report is 146 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2925   +/-   ##
=======================================
  Coverage   88.79%   88.80%           
=======================================
  Files         111      111           
  Lines       17217    17217           
=======================================
+ Hits        15288    15289    +1     
+ Misses       1929     1928    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pllim pllim pllim approved these changes

@rosteen rosteen Awaiting requested review from rosteen rosteen is a code owner

@kecnry kecnry Awaiting requested review from kecnry kecnry is a code owner

@bmorris3 bmorris3 Awaiting requested review from bmorris3 bmorris3 is a code owner

@haticekaratay haticekaratay Awaiting requested review from haticekaratay haticekaratay is a code owner

@cshanahan1 cshanahan1 Awaiting requested review from cshanahan1 cshanahan1 is a code owner

@gibsongreen gibsongreen Awaiting requested review from gibsongreen gibsongreen is a code owner

Assignees
No one assigned
Labels
no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two 💤backport-v3.10.x on-merge: backport to v3.10.x
Projects
None yet
Milestone
3.10.3
Development

Successfully merging this pull request may close these issues.
2 participants
@javerbukh @pllim